Skip to content

Notebook Controller Helm Charts #3219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 26, 2025
Merged

Notebook Controller Helm Charts #3219

merged 4 commits into from
Sep 26, 2025
+11,512 −109

Conversation

kunal-511
Copy link
Contributor

@kunal-511 kunal-511 commented Aug 19, 2025 •
edited
Loading

Pull Request Template for Kubeflow Manifests

✏️ Summary of Changes

Helm Charts for notebook-controller

📦 Dependencies

List any dependencies or related PRs (e.g., "Depends on #123").

✅ Contributor Checklist

  • I have tested these changes with kustomize. See Installation Prerequisites.
  • All commits are signed-off to satisfy the DCO check.
  • I have considered adding my company to the adopters page to support Kubeflow and help the community, since I expect help from the community for my issue (see 1. and 2.).

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@kunal-511 kunal-511 marked this pull request as draft August 19, 2025 04:26
@kunal-511 kunal-511 marked this pull request as ready for review August 21, 2025 13:40
@kunal-511
Notebook COntroller Helm Charts
ef8c9cd 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
Add crds and other remaining resources
2fed288 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511 kunal-511 force-pushed the notebook-controller-helm-chart branch from e316609 to 2fed288 Compare August 21, 2025 13:41
@kunal-511
Combine helm vs kustomize comparision gha
e5f1cb7 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@kunal-511
update .github/workflows/helm-kustomize-comparison.yml
b296444 
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@varodrig
Copy link
Contributor

@tarekabouzeid can you review?
cc @juliusvonkohout

@juliusvonkohout
Copy link
Member

Thank you
/lgtm
/approve

this is good enough as PoC

@google-oss-prow google-oss-prow bot added the lgtm label Sep 26, 2025
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8cc8dcf into kubeflow:master Sep 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusvonkohout juliusvonkohout Awaiting requested review from juliusvonkohout

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

Assignees

@juliusvonkohout juliusvonkohout

Labels

approved lgtm size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kunal-511 @varodrig @juliusvonkohout